Npm: Do not fail hard if enriching incomplete data from the NPM registry fails #5675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try fails This allows to handle packages that were never published to the NPM registry but only ever referenced by (short) repository URL. Fixes #5632. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
This is the same code as in the base class. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #5675 +/- ##
============================================
- Coverage 65.50% 65.47% -0.03%
- Complexity 2212 2219 +7
============================================
Files 271 271
Lines 16580 16592 +12
Branches 3432 3445 +13
============================================
+ Hits 10860 10863 +3
- Misses 4577 4586 +9
Partials 1143 1143
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mnonnenmacher
approved these changes
Aug 23, 2022
sschuberth
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to handle packages that were never published to the NPM
registry but only ever referenced by (short) repository URL.
Fixes #5632.